Advertise with us (we do not endorse any site advertised)

Author Topic: Still present bug just found by Hal Finney makes Bitcoin more traceable  (Read 7845 times)

0 Members and 2 Guests are viewing this topic.

Offline bitcoinforum.comTopic starter

  • Administrator
  • Legendary Member
  • *******
  • Joined: Nov 2011
  • Location: bitcoinforum.com
  • Posts: 1496
  • Country: bz
  • Thanked: 51 times
  • Karma: +39/-1
  • Gender: Male
  • The Bitcoin genie is already out of the bottle.
    • facebook.com/bitcoinforum
    • flickr.com/bitcoinforum
    • bitcoinforum.livejournal.com
    • reddit.com/user/bitcoinforum
    • stumbleupon.com/stumbler/bitcoinforum
    • bitcoinforum.tumblr.com
    • twitter.com/bitcoinforumcom
    • bitcoinforum.wordpress.com
    • View Profile
    • bitcoinforum.com
Still present bug just found by Hal Finney makes Bitcoin more traceable than expected

Posted by Hal:
Quote
Re: How to detect the change output?
Today at 01:43:57 AM
   
 #9
bitcoin-qt tries to randomize the position of the change output, but I believe the code has a flaw:

// Insert change txn at random position:
vector<CTxOut>::iterator position = wtxNew.vout.begin()+GetRandInt(wtxNew.vout.size());
wtxNew.vout.insert(position, CTxOut(nChange, scriptChange));

The problem is that size() is one in the common case of one payee, so GetRandInt will always return 0.The change ends up in the first output.

I think it should be size()+1.

https://bitcointalk.org/index.php?topic=128042.msg1398752#msg1398752
"Your keys, your Bitcoin. Not your keys, not your Bitcoin." (Andreas Antonopoulos)
Latest stable Bitcoin version
Latest stable Electrum version


 

nbr.co.nz: Bitcoin makes mainstream moves

Started by bitcoinforum.com

Replies: 0
Views: 7132
Last post December 14, 2012, 10:51:21 PM
by bitcoinforum.com
Youtube.com: Micon's how to play poker with bitcoin

Started by bitcoinforum.com

Replies: 0
Views: 9709
Last post April 10, 2012, 10:14:54 PM
by bitcoinforum.com
How a bitcoin transaction works?

Started by bitcoinforum.com

Replies: 2
Views: 13757
Last post February 22, 2014, 02:21:51 PM
by bitcoinwallettest
net-security.org: Beware of Bitcoin miner posing as Trend Micro AV

Started by bitcoinforum.com

Replies: 0
Views: 10124
Last post December 14, 2012, 05:47:39 PM
by bitcoinforum.com
Ruby Bitcoin Exchangers at risk?

Started by bitcoinforum.com

Replies: 1
Views: 3382
Last post January 31, 2013, 08:15:53 PM
by bitcoinforum.com

your ads here