Still present bug just found by Hal Finney makes Bitcoin more traceable than expected

Posted by Hal:

Re: How to detect the change output?
Today at 01:43:57 AM
   
 #9
bitcoin-qt tries to randomize the position of the change output, but I believe the code has a flaw:

// Insert change txn at random position:
vector<CTxOut>::iterator position = wtxNew.vout.begin()+GetRandInt(wtxNew.vout.size());
wtxNew.vout.insert(position, CTxOut(nChange, scriptChange));

The problem is that size() is one in the common case of one payee, so GetRandInt will always return 0.The change ends up in the first output.

I think it should be size()+1.

https://bitcointalk.org/index.php?topic=128042.msg1398752#msg1398752